-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Setup webawesome dialog and update standard dialog header design #27020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice @timmo001 !
|
|
@timmo001 for my info, is the plan to keep ha-dialog as is for now? Why I ask is that Browser Mod uses ha-dialog for popups and will need to adjust to changes if ha-dialog is to use webawesome soon. So seeking info on impacts and timing of these changes so I can plan for Browser Mod to keep up. Thanks. |
|
Yes I believe the plan is to slowly migrate over time to the new webawesome dialog and keep the original available |
TODO
Future ideasMoved to #27143 |
916b526 to
ece87af
Compare
9b10658 to
af53a51
Compare
wendevlin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still some work to do 🙂
Mobile
It sets height to 100vh, but width is still 95vw, what looks strange:

What happens if I have just a alert dialog, I don't want to have width 100vw. There should be a prop for that to define what happens on mobile.
combo box issue
I am not sure if we can fix this, because I think we have the same issue with the ha-md-dialog when I am done with the new target-picker we can test it with it, if the issue is gone.
I am just wondered that you havn't seen this issue yourself.
ideas for the future
I like the footer component, but I would like to go one step further and have some kind of dialog-button-footer which uses ha-dialog-footer but you just have to define the buttons in an array or smth. Same would be interesting for the header, to quickly define standardized dialogs.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Strange one spotted by @marcinbauer85 The tooltip/popover doesnt show on this dialog screenrecording-2025-09-26_12-00-47.mp4Everything else seems to be interactable still |
yeah I think the issue is that the dialog itself is in the |
Yeah looks to be the case, it also looks like its rendering in the wrong position:
Strange thing is this has |
|
Not sure how to fix the canvas overlay issue, seems to work OK on mobile, but not desktop |
😞 thats a deal breaker for more-info. The only idea for now is to not open the dialog in non-modal mode. |
Still confuses me how the mobile overlay seems to be fine. Does the mobile canvas overlay work different somehow? |
3491274 to
7c1c0b6
Compare
|
Also so this doesnt get lost
Also have this issue, its the same issue the graph has I guess |
|
Chart tooltips are now set to render inside the container instead of the body: screenrecording-2025-10-01_13-24-31.mp4The last one is the dropdown for targets which may be alleviated in future:
|
Co-authored-by: Wendelin <[email protected]>
Co-authored-by: Wendelin <[email protected]>
Co-authored-by: Wendelin <[email protected]>
… query for deeply nested elements (ha-form etc)
90421a4 to
3ab1506
Compare



Breaking change
Proposed change
Starting point for #27143
Currently applied to restart dialog
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: