Skip to content

Conversation

@timmo001
Copy link
Member

@timmo001 timmo001 commented Sep 12, 2025

Breaking change

Proposed change

Starting point for #27143

Currently applied to restart dialog

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@marcinbauer85
Copy link
Member

Nice @timmo001 !

  1. I've noticed on mobile it doesn't scroll correctly:
    https://github.com/user-attachments/assets/f7eff89e-acfc-4cf4-9c87-8640559c41cf

  2. The footer buttons have no margin between them

CleanShot 2025-09-12 at 15 21 15

@dcapslock
Copy link
Contributor

@timmo001 for my info, is the plan to keep ha-dialog as is for now? Why I ask is that Browser Mod uses ha-dialog for popups and will need to adjust to changes if ha-dialog is to use webawesome soon. So seeking info on impacts and timing of these changes so I can plan for Browser Mod to keep up. Thanks.

@timmo001
Copy link
Member Author

Yes I believe the plan is to slowly migrate over time to the new webawesome dialog and keep the original available

@timmo001
Copy link
Member Author

timmo001 commented Sep 17, 2025

TODO

  • Refactor to be more native
  • Remove custom implementations for initial setup
  • Use ha-dialog-header
  • One slot for the footer (use gap between items by default)
  • Standard sizes for each section of the frontend small/medium/large/full?, use medium as default (sizes TBD, set medium to current size)
  • More info has a trick to resize the dialog on the header click. See how that works and if it can be improved
  • Fix scrolling on dashboard, need to look into how/why the docs does the html tweak etc.
  • Increase the height with the more info dialog on a camera entity if not already implemented
  • Make scrolling/overflow only work inside the dialog content
  • Make enter trigger primary action

Future ideas

Moved to #27143

@timmo001 timmo001 force-pushed the ha-dialog-to-wa branch 2 times, most recently from 916b526 to ece87af Compare September 22, 2025 10:33
@timmo001 timmo001 self-assigned this Sep 23, 2025
@timmo001 timmo001 marked this pull request as ready for review September 23, 2025 13:21
Copy link
Member

@wendevlin wendevlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still some work to do 🙂

Mobile

It sets height to 100vh, but width is still 95vw, what looks strange:
Image

What happens if I have just a alert dialog, I don't want to have width 100vw. There should be a prop for that to define what happens on mobile.

combo box issue

Image

I am not sure if we can fix this, because I think we have the same issue with the ha-md-dialog when I am done with the new target-picker we can test it with it, if the issue is gone.

I am just wondered that you havn't seen this issue yourself.

ideas for the future

I like the footer component, but I would like to go one step further and have some kind of dialog-button-footer which uses ha-dialog-footer but you just have to define the buttons in an array or smth. Same would be interesting for the header, to quickly define standardized dialogs.

@home-assistant home-assistant bot marked this pull request as draft September 26, 2025 11:04
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@timmo001
Copy link
Member Author

Strange one spotted by @marcinbauer85

The tooltip/popover doesnt show on this dialog

screenrecording-2025-09-26_12-00-47.mp4

Everything else seems to be interactable still

@wendevlin
Copy link
Member

Strange one spotted by @marcinbauer85

The tooltip/popover doesnt show on this dialog

yeah I think the issue is that the dialog itself is in the top-layer but the tooltip is added to the document. But top-layer is above that 😒

@timmo001
Copy link
Member Author

timmo001 commented Sep 29, 2025

Strange one spotted by @marcinbauer85
The tooltip/popover doesnt show on this dialog

yeah I think the issue is that the dialog itself is in the top-layer but the tooltip is added to the document. But top-layer is above that 😒

Yeah looks to be the case, it also looks like its rendering in the wrong position:

image

Strange thing is this has z-index: 9999999 (renders at end of body):
image

@timmo001
Copy link
Member Author

Not sure how to fix the canvas overlay issue, seems to work OK on mobile, but not desktop

@timmo001 timmo001 requested a review from wendevlin September 30, 2025 09:41
@wendevlin
Copy link
Member

Not sure how to fix the canvas overlay issue, seems to work OK on mobile, but not desktop

😞 thats a deal breaker for more-info. The only idea for now is to not open the dialog in non-modal mode.
But this can lead to other issues and I like the fact that you can open it on the top layer.
reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/dialog

@timmo001
Copy link
Member Author

Not sure how to fix the canvas overlay issue, seems to work OK on mobile, but not desktop

😞 thats a deal breaker for more-info. The only idea for now is to not open the dialog in non-modal mode. But this can lead to other issues and I like the fact that you can open it on the top layer. reference: developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/dialog

Still confuses me how the mobile overlay seems to be fine. Does the mobile canvas overlay work different somehow?

@timmo001
Copy link
Member Author

Also so this doesnt get lost

I am not sure if we can fix this, because I think we have the same issue with the ha-md-dialog when I am done with the new target-picker we can test it with it, if the issue is gone.

I am just wondered that you havn't seen this issue yourself.

Also have this issue, its the same issue the graph has I guess

@timmo001
Copy link
Member Author

timmo001 commented Oct 1, 2025

Chart tooltips are now set to render inside the container instead of the body:

screenrecording-2025-10-01_13-24-31.mp4

The last one is the dropdown for targets which may be alleviated in future:

I am not sure if we can fix this, because I think we have the same issue with the ha-md-dialog when I am done with the new target-picker we can test it with it, if the issue is gone.

@wendevlin wendevlin merged commit 1b932ae into dev Oct 9, 2025
16 checks passed
@wendevlin wendevlin deleted the ha-dialog-to-wa branch October 9, 2025 06:16
@github-project-automation github-project-automation bot moved this from In Progress to Done in Components (Design System) Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Design Related to Home Assistant design gallery needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview

Projects

Development

Successfully merging this pull request may close these issues.

6 participants